Skip to content

Conversation

@ArqTras
Copy link

@ArqTras ArqTras commented Nov 27, 2018

No description provided.

@ArqTras ArqTras changed the title Update tag version Update checkout version Nov 27, 2018
Copy link

@stoffu stoffu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the "Recommended Aeon version" column of the "Software upgrades" table.

Copy link

@shigutso shigutso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update line 97 with 0.12.7.0-aeon too

Removed libpcsclite-dev because twice
Recommended version 0.12.7 also I suggest to set minimum version 0.12.7 because of database changes (not applied)
@ArqTras
Copy link
Author

ArqTras commented Nov 28, 2018

Removed libpcsclite-dev because twice
Recommended version 0.12.7 also I suggest to set minimum version 0.12.7 because of database changes (not applied)


Install all dependencies at once on Debian/Ubuntu:
``` sudo apt update && sudo apt install build-essential cmake git libpcsclite-dev pkg-config libboost-all-dev libssl-dev libzmq3-dev libunbound-dev libsodium-dev libminiupnpc-dev libunwind8-dev liblzma-dev libreadline6-dev libldns-dev libexpat1-dev doxygen graphviz libpcsclite-dev ```
``` sudo apt update && sudo apt install build-essential cmake git libpcsclite-dev pkg-config libboost-all-dev libssl-dev libzmq3-dev libunbound-dev libsodium-dev libminiupnpc-dev libunwind8-dev liblzma-dev libreadline6-dev libldns-dev libexpat1-dev doxygen graphviz ```
Copy link

@stoffu stoffu Nov 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This duplicate libpcsclite-dev was done in 304f157 where the last one was the existing one. So please keep the last one, and remove the one appearing in the middle.

@stoffu
Copy link

stoffu commented Nov 29, 2018

Please squash those two commits on the change of the version number. Also, for both commits, please rephrase the commit message to something more informative, e.g.:

  • README: bump tag
  • README: remove duplicated libpcsclite-dev from dependency one-liner

Also, due to a Windows-specific issue fixed in #80 , we will likely have another point release, v0.12.8.0. If this becomes the case, please update the patch accordingly.

@stoffu
Copy link

stoffu commented Nov 30, 2018

#82

@ArqTras ArqTras closed this Feb 20, 2019
@ArqTras ArqTras deleted the patch-1 branch February 20, 2019 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants