-
Notifications
You must be signed in to change notification settings - Fork 48
Update checkout version #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
stoffu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also update the "Recommended Aeon version" column of the "Software upgrades" table.
shigutso
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update line 97 with 0.12.7.0-aeon too
Removed libpcsclite-dev because twice Recommended version 0.12.7 also I suggest to set minimum version 0.12.7 because of database changes (not applied)
|
Removed libpcsclite-dev because twice |
|
|
||
| Install all dependencies at once on Debian/Ubuntu: | ||
| ``` sudo apt update && sudo apt install build-essential cmake git libpcsclite-dev pkg-config libboost-all-dev libssl-dev libzmq3-dev libunbound-dev libsodium-dev libminiupnpc-dev libunwind8-dev liblzma-dev libreadline6-dev libldns-dev libexpat1-dev doxygen graphviz libpcsclite-dev ``` | ||
| ``` sudo apt update && sudo apt install build-essential cmake git libpcsclite-dev pkg-config libboost-all-dev libssl-dev libzmq3-dev libunbound-dev libsodium-dev libminiupnpc-dev libunwind8-dev liblzma-dev libreadline6-dev libldns-dev libexpat1-dev doxygen graphviz ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This duplicate libpcsclite-dev was done in 304f157 where the last one was the existing one. So please keep the last one, and remove the one appearing in the middle.
|
Please squash those two commits on the change of the version number. Also, for both commits, please rephrase the commit message to something more informative, e.g.:
Also, due to a Windows-specific issue fixed in #80 , we will likely have another point release, v0.12.8.0. If this becomes the case, please update the patch accordingly. |
No description provided.