This repository was archived by the owner on Apr 17, 2023. It is now read-only.
Offline toggle button#113
Closed
wtrocki wants to merge 1 commit intoaerogear:masterfrom
Closed
Conversation
wtrocki
commented
Mar 19, 2019
| import { AuthService } from '../auth.service'; | ||
| import { taskCacheUpdates } from './cache.updates'; | ||
|
|
||
| export class ToggleableNetworkStatus implements NetworkStatus { |
Contributor
Author
There was a problem hiding this comment.
To be moved to separate class.
The toggable state should be also persisted in ionic store.
wtrocki
commented
Mar 19, 2019
| <ion-badge color="secondary" *ngIf="online">Online</ion-badge> | ||
| <ion-badge color="primary" *ngIf="!online">Offline</ion-badge> | ||
| </ion-label> | ||
| <ion-button color="primary" fill="outline" (click)="restart()"> |
Contributor
Author
There was a problem hiding this comment.
[Suggestion] We may bring that to the settings screen where we will enable this feature and could also use the toggle button to change status.
Contributor
Author
|
Closing as outdated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jhellar done button already that is really helpful, but it will need some refinement in order to merge that to master. We should look to bring that into master as it will help with general testing and oversight.
Let's collab on this and share ideas on how this could be done.
ping @StephenCoady @piccolazucca