This repository was archived by the owner on Apr 17, 2023. It is now read-only.
fix: added offline queue page#125
Merged
milenazuccarelli merged 18 commits intoaerogear:masterfrom Mar 26, 2019
Merged
Conversation
wtrocki
reviewed
Mar 26, 2019
|
|
||
| import { OfflineQueuePageModule } from './pages/offline-queue/offline-queue.module'; | ||
|
|
||
| export function loadOfflineQueuePageModule() { |
wtrocki
reviewed
Mar 26, 2019
| <ion-back-button defaultHref="tasks"></ion-back-button> | ||
| </ion-buttons> | ||
| <ion-title> | ||
| Offline queue |
wtrocki
reviewed
Mar 26, 2019
| {{ stagedItem.operationName }} | ||
| </ion-badge> | ||
| </h2> | ||
| <div *ngIf="stagedItem.variables.title"> |
Contributor
There was a problem hiding this comment.
Not for now but it could be simple for loop that iterates over variables as the style for all is the same. When we change schema this will silently fail.
wtrocki
reviewed
Mar 26, 2019
| } | ||
|
|
||
| public getData() { | ||
| this.stagedItems = JSON.parse( |
Contributor
There was a problem hiding this comment.
This will trigger angular bind for a millisecond. Each writes to fields of Page rewrites UI.
It will be more efficient to simply put that to var and assign it only bellow.
wtrocki
reviewed
Mar 26, 2019
| item-right | ||
| ></ion-toggle> | ||
| </ion-item> | ||
| <h4>Simulate offline in Task page</h4> |
Contributor
There was a problem hiding this comment.
To simplify review we may need to unstage this for the moment.
I think we are not ready yet to get both ideas merged. We could work on this in separate PR.
wtrocki
reviewed
Mar 26, 2019
Contributor
|
Minor lint issues: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added page to view changes staged offine