[Rust] Remove a spurious lifetime from a parameter a slice-encoding method #516
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the usability of the
*_from_slicemethod of encoding a group of fixed-size members all in one go by removing an unnecessary link between the input slice that will be copied and the output data buffer. The fact that we're copying bytes behind the curtains obviates the need to do more than be sure the slice lives for the duration of the method call.Preliminary testing also shows an ~10% performance encoding improvement over the immediate alternatives and reduces client-user temptation to apply
unsafemethods.@mjpt777