[Rust] Simplify done unwrapping to prevent dual mutable aliasing #518
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the done-state of generated rust encoders and decoders handed back a reference to the wrapped data buffer and a the final position read/written to. Now only the final position is provided.
This ensures that it is impossible for the mutable references data struct overlays optionally created during encoding to coexist with a same-lifetime'd mutable byte slice produced at the end. Since the final position is still returned, and the original input buffers were all slice-references anyhow, users should be able to trivally re-slice the source data equivalently themselves without loss of functionality.
A minor performance gain is also accomplished because returning a
usizeis marginally cheaper than returning a newly-allocated tuple containing a usize and a slice-reference.@mjpt777