Skip to content

Conversation

@rigtorp
Copy link
Contributor

@rigtorp rigtorp commented Jun 10, 2019

This will cover everything except Redhat 7 I think.

@rigtorp rigtorp force-pushed the add-new-compilers branch from 9bd65c0 to 3520c9d Compare June 10, 2019 04:32
@rigtorp rigtorp force-pushed the add-new-compilers branch from 3520c9d to a730646 Compare June 10, 2019 04:47
@tmontgomery tmontgomery merged commit 35d6f60 into aeron-io:master Jun 11, 2019
language: java
jdk: openjdk8
os: linux
dist: xenial
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this changed to default? The default for Travis is 14.04 when most people are on 16.04 or later.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct me if I am wrong.... Xenial is 16.04 LTS. Isn't it the latest LTS? Bionic is 18.04 LTS. Not sure it's image in Travis is that stable yet, though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmontgomery You are correct. However Travis default is Trusty. https://docs.travis-ci.com/user/reference/overview/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trusty being 5 years old.... shouldn't it be compiling against a newer version? I'm just making the argument as I see it. I don't know if the PR author had any other reason or reasons. Maybe @rigtorp can weigh in.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it to be Xenial to be more recent and now it is reverted.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't xenial now the default at the top? Making it unnecessary to specify it on each one?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed that. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants