-
Notifications
You must be signed in to change notification settings - Fork 556
Add new compilers #689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new compilers #689
Conversation
9bd65c0 to
3520c9d
Compare
3520c9d to
a730646
Compare
| language: java | ||
| jdk: openjdk8 | ||
| os: linux | ||
| dist: xenial |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this changed to default? The default for Travis is 14.04 when most people are on 16.04 or later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct me if I am wrong.... Xenial is 16.04 LTS. Isn't it the latest LTS? Bionic is 18.04 LTS. Not sure it's image in Travis is that stable yet, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tmontgomery You are correct. However Travis default is Trusty. https://docs.travis-ci.com/user/reference/overview/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trusty being 5 years old.... shouldn't it be compiling against a newer version? I'm just making the argument as I see it. I don't know if the PR author had any other reason or reasons. Maybe @rigtorp can weigh in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed it to be Xenial to be more recent and now it is reverted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't xenial now the default at the top? Making it unnecessary to specify it on each one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed that. Sorry.
This will cover everything except Redhat 7 I think.