Skip to content

[C++] Make sure all members are initilized #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2019
Merged

[C++] Make sure all members are initilized #726

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions sbe-tool/src/main/java/uk/co/real_logic/sbe/generation/cpp/CppGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,14 +197,14 @@ private static void generateGroupClassHeader(
indent + "class %1$s\n" +
indent + "{\n" +
indent + "private:\n" +
indent + " char *m_buffer;\n" +
indent + " std::uint64_t m_bufferLength;\n" +
indent + " std::uint64_t *m_positionPtr;\n" +
indent + " std::uint64_t m_blockLength;\n" +
indent + " std::uint64_t m_count;\n" +
indent + " std::uint64_t m_index;\n" +
indent + " std::uint64_t m_offset;\n" +
indent + " std::uint64_t m_actingVersion;\n\n" +
indent + " char *m_buffer = nullptr;\n" +
indent + " std::uint64_t m_bufferLength = 0;\n" +
indent + " std::uint64_t *m_positionPtr = nullptr;\n" +
indent + " std::uint64_t m_blockLength = 0;\n" +
indent + " std::uint64_t m_count = 0;\n" +
indent + " std::uint64_t m_index = 0;\n" +
indent + " std::uint64_t m_offset = 0;\n" +
indent + " std::uint64_t m_actingVersion = 0;\n\n" +

indent + " SBE_NODISCARD std::uint64_t *sbePositionPtr() SBE_NOEXCEPT\n" +
indent + " {\n" +
Expand Down Expand Up @@ -1619,9 +1619,9 @@ private CharSequence generateFixedFlyweightCode(final String className, final in
return String.format(
"private:\n" +
" char *m_buffer = nullptr;\n" +
" std::uint64_t m_bufferLength;\n" +
" std::uint64_t m_bufferLength = 0;\n" +
" std::uint64_t m_offset = 0;\n" +
" std::uint64_t m_actingVersion;\n\n" +
" std::uint64_t m_actingVersion = 0;\n\n" +

"public:\n" +
" enum MetaAttribute\n" +
Expand Down Expand Up @@ -1772,8 +1772,8 @@ private CharSequence generateMessageFlyweightCode(final String className, final
" char *m_buffer = nullptr;\n" +
" std::uint64_t m_bufferLength = 0;\n" +
" std::uint64_t m_offset = 0;\n" +
" std::uint64_t m_position;\n" +
" std::uint64_t m_actingVersion;\n\n" +
" std::uint64_t m_position = 0;\n" +
" std::uint64_t m_actingVersion = 0;\n\n" +

" inline std::uint64_t *sbePositionPtr() SBE_NOEXCEPT\n" +
" {\n" +
Expand Down