-
Notifications
You must be signed in to change notification settings - Fork 0
FMWK-729 Restructure API and ConditionVisitor, build Filter and Exp in one run #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…date it, other refactoring
…te API, add tests
…d resulting tree and pair of results to ParsedExpression, refactoring
… rename Pair, add javadoc, update tests
…pace, document exceptions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR restructures the DSL API by consolidating expression and filter building in one run while removing legacy model classes and updating the AbstractPart hierarchy. Key changes include:
- Moving and updating classes from the model package to the parts package, notably AbstractPart now uses Filter instead of SIndexFilter.
- Removing legacy operand and CDT classes and introducing new classes (ParsedExpression, ParseResult, IndexContext, and Index) to support the updated API.
- Updating the DSLParser and its implementation to integrate the new processing logic and API flow.
Reviewed Changes
Copilot reviewed 86 out of 86 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/com/aerospike/dsl/parts/cdt/CdtPart.java | New abstract class for CDT parts with updated error reporting. |
| src/main/java/com/aerospike/dsl/parts/ExpressionContainer.java | New class representing expression containers with unary and binary operators. |
| src/main/java/com/aerospike/dsl/parts/AbstractPart.java | Updated to replace SIndexFilter with Filter and adjust constructors accordingly. |
| src/main/java/com/aerospike/dsl/model/* | Multiple legacy files removed (CdtPart, VariableOperand, StringOperand, SIndexFilter, ParsedOperand, MapOperand, ListOperand, IntOperand, Expr, AerospikeDSLException). |
| src/main/java/com/aerospike/dsl/ParsedExpression.java, ParseResult.java, IndexContext.java, Index.java, DslParseException.java | New classes to support the updated DSL parsing and processing API. |
| src/main/java/com/aerospike/dsl/DSLParserImpl.java, DSLParser.java | Redesigned methods to return ParsedExpression and support index context handling. |
Uh oh!
There was an error while loading. Please reload this page.