FMWK-733 Add support for expression placeholders #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrgr
changed the title
…e traversing expr. tree instead of when parsing, add tests
| */ | ||
| private static Filter getFilterOrFail(AbstractPart left, AbstractPart right, FilterOperationType type) { | ||
| validateOperands(left, right); | ||
| private static Filter getFilterOrFail(AbstractPart left, AbstractPart right, FilterOperationType type, |
There was a problem hiding this comment.
nit: the method should be renamed to getFilterOrNull since if nothing matches we don't raise an error but return null.
| * @return A {@link Filter} if one can be generated, otherwise {@code null} | ||
| * @throws NoApplicableFilterException if the expression structure is not supported for filtering | ||
| */ | ||
| private static Filter getFilterFromExpressionOrFail(AbstractPart exprLeft, AbstractPart exprRight, |
There was a problem hiding this comment.
nit: the method should be renamed to getFilterFromExpressionOrNull since if nothing matches we don't raise an error but return null.
mirzakaracic
left a comment
mirzakaracic
left a comment
There was a problem hiding this comment.
Couple nits other than that it looks great to me.
👍
Contributor
Author
|
Added support for more complicated expressions, refactored implementation, added tests |
reugn
reviewed
Aug 28, 2025
src/main/java/com/aerospike/dsl/parts/operand/OperandFactory.java
Outdated
Show resolved
Hide resolved
reugn
changed the title
…ck placeholder values for null, add tests
reugn
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.