FMWK-840 Update Maven release workflow #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.github/workflows/maven-release.yml
Outdated
| with: | ||
| maven-version: 3.9.6 | ||
|
|
||
| - name: Configure GPG for CI environment |
There was a problem hiding this comment.
Why don't you just use the GPG setup during JDK
https://github.com/actions/setup-java/blob/main/docs/advanced-usage.md#yaml-example
Contributor
Author
There was a problem hiding this comment.
Did not quite want to change pom.xml or call setup more than once, also wanting to make the solution robust and configured in one place. Updated with a compromise: using built-in GPG handling with few additional parameters to prevent errors like ioctl while eliminating a separate GPG configuration step
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include commands to allow GPG signing in a headless CI/CD environment