Skip to content

Conversation

javilinos
Copy link
Member


Basic Info

Info Please fill out this column
Issue(s) this addresses sim to real objects
ROS2 version tested on Humble
Aerial platform tested on Ignition

Description of contribution in a few bullet points

  • Added use_sim_time parameter to as2_ign_gazebo_assets
  • use_sim_time to false deactivates sim clock and make external objects publish their tf in system clock

Description of documentation updates required from your changes

  • Maybe some sim to real stuff as we are using objects from simulation publishing tf's in system clock so they can be used in a real test and be visualized in rviz.

@javilinos javilinos requested a review from pariaspe March 24, 2023 11:58
@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2023

Codecov Report

Merging #203 (f88a6cc) into main (f2d29d5) will increase coverage by 0.07%.
The diff coverage is n/a.

❗ Current head f88a6cc differs from pull request most recent head 16b7582. Consider uploading reports for the commit 16b7582 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff            @@
##            main    #203      +/-   ##
========================================
+ Coverage   3.13%   3.21%   +0.07%     
========================================
  Files         99      99              
  Lines       5135    5201      +66     
  Branches     451     476      +25     
========================================
+ Hits         161     167       +6     
- Misses      4836    4868      +32     
- Partials     138     166      +28     
Flag Coverage Δ
unittests 3.21% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 21 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pariaspe pariaspe merged commit cb1bb98 into main Mar 24, 2023
@pariaspe pariaspe deleted the simulation_assets_for_windmill_test branch March 24, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants