Skip to content

Conversation

pariaspe
Copy link
Member

@pariaspe pariaspe commented May 4, 2023

Basic Info

Info Please fill out this column
Issue(s) this addresses -
ROS2 version tested on Humble
Aerial platform tested on Ignition

Description of contribution in a few bullet points

  • JSON world description are now validated through pydantic
  • Data models are simplified and reorganized, parsing is no longer done manually

@pariaspe pariaspe requested a review from RPS98 May 4, 2023 10:43
@codecov-commenter
Copy link

codecov-commenter commented May 4, 2023

Codecov Report

Merging #232 (58ed464) into main (8b6fa67) will increase coverage by 0.07%.
The diff coverage is n/a.

❗ Current head 58ed464 differs from pull request most recent head f85b839. Consider uploading reports for the commit f85b839 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff            @@
##            main    #232      +/-   ##
========================================
+ Coverage   3.07%   3.14%   +0.07%     
========================================
  Files        100     100              
  Lines       5244    5311      +67     
  Branches     451     476      +25     
========================================
+ Hits         161     167       +6     
- Misses      4945    4978      +33     
- Partials     138     166      +28     
Flag Coverage Δ
unittests 3.14% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 22 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@miferco97 miferco97 merged commit 88bcb58 into main May 5, 2023
@RPS98 RPS98 deleted the launch_gz_v2 branch June 7, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants