Fix RaveledParamsMap dtypes #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dtype of parameters can change as they get successively raveled and unraveled. In this PR we add a property to RaveledParamsMap that keeps track of dtypes.
brandonwillard
approved these changes
Jun 22, 2022
|
The test that fails is unrelated to the current PR, it seems related to a recent change in |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dtype of parameters can change as they get successively raveled and unraveled. This is problematic when sampling from the posterior distribution of a model whose observation distribution is discrete. In this PR we add a property to RaveledParamsMap that keeps track of dtypes.