Clean up JSON Schema #252
Merged
Clean up JSON Schema #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We made some changes in the past to inline a bunch of $refs to make things easier for sdk generation. However, this came with downsides of less distinct types. This should have a more compatible version, that still preserves the non-inlined types. At least on the TypeScript side this has vastly improved the generated types.
anna239
approved these changes
Nov 20, 2025
Helps with compatibility of more JSON Schema variants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We made some changes in the past to inline a bunch of $refs to make
things easier for sdk generation. However, this came with downsides of
less distinct types.
This should have a more compatible version, that still preserves the
non-inlined types.
At least on the TypeScript side this has vastly improved the generated
types.