fix(issue #27): added an optional limit parameter #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sport and stdio_streams Signed-off-by: Chojan Shang <chojan.shang@vesoft.com>
Member
Author
|
cc @OhadRubin, could you please review this? |
OhadRubin
reviewed
Nov 13, 2025
OhadRubin
left a comment
OhadRubin
left a comment
There was a problem hiding this comment.
LGTM, I do have some nitpicks but this looks fine.
Might set a more reasonable default?
Member
Author
Good idea, but it seems that in UI displays, most modern tools collapse content (and don't allow expansion) to avoid overwhelming users with large amounts of information. I'd like to consult @stdrc , who built kimi-cli, as it's one of the primary use cases at present. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #27