Skip to content

Conversation

@frostming
Copy link
Contributor

@frostming frostming commented Nov 19, 2025

Summary

Change the field names for models to be snake case

Constructing the models should be backward-compatible, but accessing is not:

req = InitializeRequest(protocolVersion=1)  # valid
req = InitializeRequest(protocol_version=1)  # valid
req.protocolVersion  # AttributeError
req.protocol_version  # valid

So this should be considered a breaking change, should better open a dedicated branch and merge to it.

Checklist

  • Conventional Commit title (e.g. feat:, fix:).
  • Tests cover the change or are not required (explain above).
  • Docs/examples updated when behaviour is user-facing.
  • Schema regenerations (make gen-all) are called out if applicable.

Signed-off-by: Frost Ming <me@frostming.com>
Signed-off-by: Frost Ming <me@frostming.com>
@PsiACE PsiACE changed the base branch from main to 0.7.x November 19, 2025 06:46
Copy link
Member

@PsiACE PsiACE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

It's great to have a true Python expert helping us with this.

Just a heads-up: I've prepared a branch named 0.7.x as the target branch. I plan to introduce these significant pythonic changes in the next protocol version release.

@PsiACE PsiACE merged commit 571766a into agentclientprotocol:0.7.x Nov 19, 2025
7 checks passed
@frostming frostming deleted the feat/snake-case-fields branch November 19, 2025 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants