Skip to content

Conversation

@frostming
Copy link
Contributor

@frostming frostming commented Nov 19, 2025

Summary

Related issues

Testing

Docs & screenshots

Checklist

  • Conventional Commit title (e.g. feat:, fix:).
  • Tests cover the change or are not required (explain above).
  • Docs/examples updated when behaviour is user-facing.
  • Schema regenerations (make gen-all) are called out if applicable.

Signed-off-by: Frost Ming <me@frostming.com>
Copy link
Member

@PsiACE PsiACE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

We still depend on the post-generation overrides in scripts/gen_schema.py: without them, datamodel-code-generator produces plain str fields (e.g. PromptResponse.stop_reason) and dict defaults (e.g. AgentCapabilities.mcp_capabilities). The current warnings (“failed to override default…”) happen because --snake-case-field renamed the generated attributes (stop_reason, mcp_capabilities, etc.), while the override lists still use camelCase. Before we carry these fixes forward, could you confirm whether you still expect these override steps to remain, or if you have a better approach in mind?

Signed-off-by: Frost Ming <me@frostming.com>
@frostming
Copy link
Contributor Author

Thanks, overrides config is fixed

Copy link
Member

@PsiACE PsiACE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 💯 🥇 ❤️

@PsiACE PsiACE merged commit 856ea0d into agentclientprotocol:0.7.x Nov 20, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants