Skip to content

Conversation

@giucris
Copy link
Contributor

@giucris giucris commented Apr 21, 2022

Changed TagCategory to TagLabel on Tag fields description.

@giucris giucris force-pushed the feature/update-tag-fields branch from fe05d44 to cd3b75c Compare April 21, 2022 18:06
Copy link
Contributor

@agile-lab agile-lab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you think is better to use tagLabel ? tagLabel is a schema, while tagProperty is an Entity and it seems to me more powerful than the other one

@giucris
Copy link
Contributor Author

giucris commented May 20, 2022

Hi @agile-lab.

I have taken inspiration from how open metadata uses tags.
For example in the definition of a table or its schema open metadata use the tagLabel (https://docs.open-metadata.org/metadata-standard/schemas/entities/table)

Since in the definition of the output schema we use the open metadata standard and therefore use taglabels this makes everything more straightforward. otherwise we would have, in our yaml, field tags that have to be composed differently, someone that use tagCategory some otherone that use tagLabel.

Furthermore, in this way could be possible to establish the construction of the TagCategory, the entities, only on the federated governance or at domain level, whereas in the data product and in all components we can only link to a predefined tag.

@SpyQuel SpyQuel merged commit 4226bc2 into agile-lab-dev:main Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants