[CocoaPods 0.36.0.rc.1 issues] Renaming Dynamic Library Install Name

[steilerDev]

I want to integrate the 1Password extension to my Swift application. I am using CocoaPods to integrate your extension into my application. Concluding I needed to use an Objective-C bridging header.

I had big troubles integrating the extension using this approach, because I was not able to import the required header files using the intuitive command #import <1PasswordExtension/OnePasswordExtension.h, because xCode was unable to find the header file.

The configuration provided by CocoaPods the dynamic library install name is _1PasswordExtension, concluding I need to import the extension using the very non-intuitive #import <_1PasswordExtension/OnePasswordExtension.h command.

It would be great to either include a notice about this non-intuitive behaviour or change the name within the next release.

[radazzouz]

Hi @steilerDev,

Thanks for taking the time to write in 👍

The library is be named 1PasswordExtension and not _1PasswordExtension in both our podsepc and and in CocoaPods/Specs.

I am not sure I fully understand the issue, because I cannot reproduce it. Could it be an Xcode or a Swift issue? Could you please send us a sample project so we can try and figure it out on our end?

I look forward to your reply 😄

Enjoy your weekend!

[tapi]

@steilerDev what version of cocoapods are you using? I did up the pods pec originally but haven't been working with any of the recent betas. I know 0.36 adds framework support but I'm not sure how they are named.

[steilerDev]

@radazzouz: I've now pushed my current project:
You can see the usage of your extension in my LoginViewController and within my Objective-C bridging header. Notice that I had to use import _1PasswordExtension, respectively #import <_1PasswordExtension/OnePasswordExtension.h> to use the extension.

And yes it might be a xCode or Swift issue, I just don't know

@tapi I am using 0.36.0.rc.1 since I need swift framework support

[radazzouz]

Hi @steilerDev,

I created a sample project in Objective-C based on ACME. I installed CocoaPods 0.36.0.rc.1 and set it up. Please refer to the Podfile in the attached sample project.

Note that I used #import "OnePasswordExtension.h" and not #import <_1PasswordExtension/OnePasswordExtension.h> or #import <1PasswordExtension/OnePasswordExtension.h>.

Can you please modify the sample project and send it back to me so I can reproduce the issue here. This way we can clearly determine whether it's an issue that we can fix ourselves or whether it's an Xcode, Swift or CocoaPods issue.

Cheers!

[tapi]

Sorry @radazzouz I did look into this. Theres a blog post here

TL;DR
I think module_name = '1PasswordExtension' should be added to the Podfile. Haven't/Don't really have time to test @steilerDev are you able to make this change and see if that cleans up the import?

[radazzouz]

@tapi where should this change be made? Should we make it in the 1PasswordExtension.podspec in this repo or should it be made by developers who are using CocoaPods in their project's Podfile?

[tapi]

Should be made in the podspec. The actual name can be whatever you want

[radazzouz]

Now I see. Thanks @tapi! I wonder if this change would work with CocoaPods 0.35 stable.

We don't want to make this change only for developers who use the pre-release version and break the compatibility to the stable version.

We should make sure that this change works with both the stable and pre-release versions of CocoaPods.

[steilerDev]

In your project there is no dynamic library install name (I think this is due to the fact that you are using static libraries within Obj-C)

Within my project a dynamic library name is automatically given by cocoapods, so it should be because of your pop configuration. The name there is _1PasswordExtension

[tapi]

It shouldn't affect previous versions of Cocoapods since the podspec is basically just a ruby dict that Cocoapods reads. It doesn't care about the presence of extra keys just the absence of required ones.

[steilerDev]

@radazzouz: If you are concerned about compatibility: A note within the readme would be a great start. I don't have a problem of importing _1PasswordExtension, but it was hard finding out that I had to use this syntax. Took me several hours to find out ;)