-
Notifications
You must be signed in to change notification settings - Fork 312
Update constraints for iPhone screen so the "Sign Up" button is visible #213
Update constraints for iPhone screen so the "Sign Up" button is visible #213
Conversation
|
Looks good @ghecho! 👍 Can you please make the same change to the Thanks! |
|
Sure. I will and I'll submit a PR
|
|
You could do it it in this very PR. No need for another 😉 |
|
Sure. Didn't think of that, I'll do that. 👍
|
|
I just pushed the Objective-C layout fix but I just noticed that somehow there're some conflicts. Do you have any idea of why? I'm investigating right now. |
|
I think I now know. I think you pushed some changes after I made my changes. I'll try to resolve this so it can be automatically merged unless you have a better idea. |
…on the iPhone Signed-off-by: Diego <ghecho@gmail.com> Conflicts: Demos/App Demo for iOS/App Demo for iOS/Base.lproj/Main.storyboard Fix for merge conflicts Fix layout issue on the iPhone in the Swift and Objective-C version
6758c61 to
9361919
Compare
|
I did a force-push with the fix right now. Here're my steps:
|
|
Also I had to fix a merge conflict with some internal version of the storyboard (it's super fun to manage this Xcode file changes in git) but I did tried both versions and they seemed to be working, in any case, let me know what you think. |
|
Thanks so much for helping out @ghecho 👍 The PR looks good now. I'll merge it! Cheers! |
Update constraints for iPhone screen so the "Sign Up" button is visible
|
Sure, happy to help. Cheers! |
The sign up button was not appearing so I moved it a bit to the top (I didn't move the hidden textfield of the one time generated password).