-
Notifications
You must be signed in to change notification settings - Fork 64
ModulesGarden #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ModulesGarden #41
Conversation
Added:
- Separate backend and frontend configuration
- Separate zendesk API accounts
- All tickets tab
- Dashboard ticket statistics
- User selection while ticket creating
- Order selection while ticket creating
- SSO authetification
- Magento customer and finance data with Zendesk end-user profile synchronization
Fixed:
- Client loose all tickets if change email in magento
- Ajax test connection
- UI fixes
- Tickets created from "Feedback Tab" or "Contact Us" do not show thread in module ticket list
- Several language improvements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've got a license fine in the root of the repo (https://github.com/zendesk/magento_extension/blob/master/LICENSE). I'm happy to not have these at the top of each file going forward.
Added Default Sort/Dir Options Added Side Ticket Statistics on Zendesk Dashboard Statistics enable/disable options Version changed Magento Integration App strip header bug fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation is out here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation looks off here
|
@max-mi this is looking really good - just a few style final nit-picks which I've commented on, then I'd be happy to merge. |
Migrate Settings 1.3.0/1-1.4.0, SSO Tickets Links From Customer View, SSO Ticket Link When Ticket is Created
Refactor addFieldToFilter method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When would this exception be thrown? Seems like we're being too defensive here and also throwing exactly the same error wouldn't help with debugging.
|
👍 |
New config, dashboards, user & order selection when creating tickets, better SSO, user syncing and fixes.
Added:
- Separate backend and frontend configuration
- Separate zendesk API accounts
- All tickets tab
- Dashboard ticket statistics
- User selection while ticket creating
- Order selection while ticket creating
- SSO authetification
- Magento customer and finance data with Zendesk end-user profile synchronization
Fixed:
- Client loose all tickets if change email in magento
- Ajax test connection
- UI fixes
- Tickets created from "Feedback Tab" or "Contact Us" do not show thread in module ticket list
- Several language improvements