Skip to content

Conversation

@joseconsador
Copy link
Contributor

[MI-100]

Save authenticated flag to the database.
Do not display Create Ticket and Dashboard/Grid if the extension is not setup properly.

Steps to reproduce:

  1. Login to the magento backend.
  2. Go to Zendesk > Configuration.
  3. In the General tab, make all fields empty except for Zendesk Domain.
    In the Admin Backend tab, set "Show support tickets on admin dashboard" to "Yes".
  4. Click Save.
  5. Go to Zendesk > Dashboard

Expected Result:

  1. "Couldn't authenticate you" should appear as an error message.
  2. On step Support for French, German, Japanese + more #5 - the configuration notice should be displayed

Actual Result:

  1. A php warning (attached) appears, along with the standard error message.

screen shot 2015-06-22 at 3 48 57 pm

  1. On step Support for French, German, Japanese + more #5 - a fatal error is thrown and halts the process (attached)

screen shot 2015-06-22 at 4 00 41 pm

/cc @miogalang @jwswj @mmolina @atroche

References

Risks

  • Medium - Extension functionality may be affected.

QA notes

  • Developer mode must be enabled

Do not display Create Ticket and Dashboard/Grid if the extension is not setup properly.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put the bumping in a new commit

@miogalang
Copy link
Contributor

👍

@jwswj
Copy link
Contributor

jwswj commented Jun 24, 2015

Can't we just check the domain name, username and password/token fields, rather than introducing a new key-value?

@joseconsador
Copy link
Contributor Author

@jwswj Those values could be incorrect, which will cause the extension to make some API calls that returns unexpected responses.

@jwswj
Copy link
Contributor

jwswj commented Jun 24, 2015

I'm on 👎 on this until we find an approach which doesn't involve saving an attribute based on successful auth. The reason being Magento can't always know about auth. What about is the token gets changed from inside Zendesk, this error would still happen. Or if someone changes their subdomain and forgets to update the Magento settings.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line causes an error. 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants