Solving memory leak when saving a customer #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 18, 2015 16:11
See issue #70. Customers with a long history of orders can not place orders if their customer account "save" triggers.
Don't forget customers with 0 orders of course
Contributor
There was a problem hiding this comment.
@MarshallHouse Semi-colon needs to be aligned.
Can we do this minor change while bumping versions? @jwswj
Contributor
|
Confirmed working, but I had to set memory_limit down to 32M to replicate the issue in #70 . NotesI have a gist or database available we can use for testing. (adding thousands of orders to a customer) 👍 /cc @miogalang @jwswj @iandjx |
Contributor
|
👍 |
Move semi-colons
joseconsador
added a commit
that referenced
this pull request
Sep 7, 2015
Solving memory leak when saving a customer
Contributor
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #70, #87. Customers with a long history of orders can not place orders if their customer account "save" triggers.