Skip to content

Commit a805e83

Browse files
committed
drop last mentions of logstash
1 parent 91ff69d commit a805e83

3 files changed

Lines changed: 2 additions & 25 deletions

File tree

action.mli

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ val config_lines : string -> string list
201201
(** Time utilities *)
202202

203203
(** Basic timer. Also allows recording a sequence of interesting times from the given start point.
204-
Can serialize recorded events to json (useful for Logstash events) *)
204+
Can serialize recorded events to json *)
205205
class timer_start : Time.t ->
206206
object
207207
method record : string -> Time.t -> unit

dune

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@
4141
(per_module
4242
((pps lwt_ppx)
4343
httpev
44-
logstash
4544
lwt_flag
4645
lwt_util
4746
parallel

var.mli

Lines changed: 1 addition & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
(**
22
Global register for various types of counters.
3-
{!Logstash} module will send all [Var] counters to logstash automatically.
4-
Counters must be mononotonically increasing for logstash to send correct deltas to Elasticsearch.
53
*)
64

75
type attributes = (string * string) list
@@ -25,27 +23,7 @@ object
2523
method show : string
2624
end
2725

28-
(** [cc pp type ?attr key] new set of counters with designated [type], [attr]ibutes and [key] name
29-
30-
Logstash events will have attributes as follows :
31-
* all of [attr] key value pairs (if given)
32-
* class=[type]
33-
* [key]=X where X is value inserted into [CC]
34-
35-
Guidelines for picking names :
36-
keep number of different [key] names low (makes ES happy),
37-
uniqueness of events is primarily provided by [class].
38-
39-
Bad example :
40-
let pages = new Var.cc "tool.pages" "pages"
41-
let index = new Var.cc "tool.index" "index"
42-
let count = new Var.cc "tool.count" "count"
43-
44-
Better :
45-
let pages = new Var.cc "tool.pages" "kind"
46-
let pages = new Var.cc "tool.index" "kind"
47-
let pages = new Var.cc "tool.count" "kind"
48-
*)
26+
(** [cc pp type ?attr key] new set of counters with designated [type], [attr]ibutes and [key] name *)
4927
val cc : ('a -> string) -> string -> ?attr:attributes -> string -> 'a Cache.Count.t
5028

5129
(** [cc pp type ?attr key] new set of counters with designated [type], [attr]ibutes and [key] name, treated as milliseconds *)

0 commit comments

Comments
 (0)