Skip to content

Commit 358dab3

Browse files
lukstafilukstafi
committed
Fix initialization order bug in init_params, spotted by Claude Code; cleanup moons_demo tests
Signed-off-by: Lukasz Stafiniak <lukstafi@gmail.com>
1 parent 0749ed3 commit 358dab3

15 files changed

+335
-739
lines changed

‎arrayjit/lib/backends.ml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -505,6 +505,8 @@ module Raise_backend (Device : Lowered_backend) : Backend = struct
505505
user can choose to run initialization code on multiple streams redundantly, or on the owner
506506
stream only and then to use init_from_device. *)
507507
if node.Low_level.read_only || Tn.known_constant key then (
508+
if not node.Low_level.read_only then
509+
[%log "Backends.alloc_if_needed: constant node is not read-only", (key : Tnode.t)];
508510
if Tn.known_non_cross_stream key then add_new_exn ()
509511
else
510512
let read_only_buffer : Device.buffer_ptr =

‎bin/dune‎

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -73,30 +73,6 @@
7373
(pps ppx_here ppx_ocannl ppx_minidebug))
7474
(modes exe))
7575

76-
(executable
77-
(name micrograd_demo)
78-
(modules micrograd_demo)
79-
(libraries ocannl base stdio datasets)
80-
(preprocess
81-
(pps ppx_here ppx_sexp_conv ppx_ocannl ppx_minidebug))
82-
(modes exe))
83-
84-
(executable
85-
(name moons_demo)
86-
(modules moons_demo)
87-
(libraries ocannl base stdio datasets)
88-
(preprocess
89-
(pps ppx_here ppx_sexp_conv ppx_ocannl ppx_minidebug))
90-
(modes exe))
91-
92-
(executable
93-
(name moons_demo_parallel)
94-
(modules moons_demo_parallel)
95-
(libraries ocannl base stdio datasets)
96-
(preprocess
97-
(pps ppx_here ppx_ocannl))
98-
(modes exe))
99-
10076
(executable
10177
(name micrograd_demo_logging)
10278
(modules micrograd_demo_logging)

‎bin/micrograd_demo.ml‎

Lines changed: 0 additions & 161 deletions
This file was deleted.

‎bin/moons_demo.ml‎

Lines changed: 0 additions & 123 deletions
This file was deleted.

0 commit comments

Comments
 (0)