Fix so it works with ppx_minidebug disabled at compile time

lukstafi · lukstafi · commit d164ae891db2 · 2025-08-04T19:01:17.000+02:00
diff --git a/arrayjit/lib/backend_impl.ml b/arrayjit/lib/backend_impl.ml
@@ -66,6 +66,8 @@ module No_device_buffer_and_copying () :
   let sexp_of_void_buffer_ptr (p : void_buffer_ptr) =
     Sexp.Atom (Ctypes_value_printing_stubs.string_of_pointer p)
 
+  let () = ignore sexp_of_void_buffer_ptr
+
   let%track7_sexp memcpy ~(dst : void_buffer_ptr) ~(src : void_buffer_ptr) ~(size_in_bytes : int) :
       unit =
     if Ctypes_ptr.Fat.compare dst src <> 0 then
diff --git a/arrayjit/lib/tnode.ml b/arrayjit/lib/tnode.ml
@@ -794,4 +794,4 @@ let%debug_sexp log_accessible_headers ?(pred = fun _ -> true) () =
     Registry.fold (fun arr acc -> if pred arr then (arr.id, header arr) :: acc else acc) registry []
   in
   List.sort results ~compare:(fun (a, _) (b, _) -> compare_int a b)
-  |> List.iter ~f:(fun (_, header) -> [%log header])
+  |> List.iter ~f:(fun (_, _header) -> [%log _header])
diff --git a/arrayjit/lib/utils.ml b/arrayjit/lib/utils.ml
@@ -431,8 +431,11 @@ let _get_local_debug_runtime = get_local_debug_runtime
 
 let%diagn_sexp set_log_level level =
   settings.log_level <- level;
-  Debug_runtime.log_level := level;
-  [%log "Set log_level to", (level : int)]
+  [%log
+    "Set log_level to",
+    (Debug_runtime.log_level := level;
+     level
+      : int)]
 
 let restore_settings () =
   set_log_level original_log_level;
@@ -713,9 +716,9 @@ let header_sep =
   compile (seq [ str " "; opt any; str "="; str " " ])
 
 let%diagn_sexp log_trace_tree _logs =
-  let sep s = String.concat ~sep:"\n" @@ String.split ~on:'$' s in
   [%log_block
     "trace tree";
+    let sep s = String.concat ~sep:"\n" @@ String.split ~on:'$' s in
     let rec loop = function
       | [] -> []
       | line :: more when String.is_empty line -> loop more
diff --git a/lib/tensor.ml b/lib/tensor.ml
@@ -722,14 +722,14 @@ let to_printbox ?single_node ?embedded_only ?entries_per_axis ?(with_id = false)
     ~with_grad t
   |> PrintBox_utils.reformat_dag depth
 
-let log_debug_info ~from_log_level t =
-  let%diagn_sexp log_child { subtensor = _subtensor; embedded = _embedded } =
-    [%logN_block
-      from_log_level
-        ((if _embedded then "Embedded " else "Non-embedded ") ^ Tn.debug_name _subtensor.value);
-      Tn.log_debug_info ~from_log_level _subtensor.value]
-  in
+let%debug_sexp log_debug_info ~from_log_level t =
   [%diagn_sexp
+    let%diagn_sexp log_child { subtensor = _subtensor; embedded = _embedded } =
+      [%logN_block
+        from_log_level
+          ((if _embedded then "Embedded " else "Non-embedded ") ^ Tn.debug_name _subtensor.value);
+        Tn.log_debug_info ~from_log_level _subtensor.value]
+    in
     [%logN_block
       from_log_level ("Tensor " ^ Tn.dims_to_string t.value);
       Tn.log_debug_info ~from_log_level t.value;
