Missing from previous commit

lukstafi · lukstafi · commit d394ebe72466 · 2025-11-30T18:16:21.000+01:00
diff --git a/arrayjit/lib/indexing.ml b/arrayjit/lib/indexing.ml
@@ -139,7 +139,8 @@ type projections = {
       *)
   product_iterators : symbol array;
       (** The product space iterators (concatentation of the relevant batch, output, input axes) for
-          iterating over the [product_space] axes, where same axes are at same array indices. *)
+          iterating over the [product_space] axes, where same axes are at same array indices.
+          These may be shared; lowering creates fresh symbols for loop indices. *)
   project_lhs : axis_index array;
       (** A projection that takes an [product_space]-bound index and produces an index into the
           result of an operation. *)
diff --git a/tensor/row.mli b/tensor/row.mli
@@ -36,8 +36,8 @@ and dim =
   | Dim of solved_dim
   | Affine of { stride : int; over : dim; conv : convolution option; stride_offset : int }
       (** An affine transformation of a dimension. When [conv] is [None], this is a simple strided
-          dimension. When [conv] is [Some], this includes convolution parameters.
-          Invariants: [stride > 0], [dilation > 0] (when present), [0 <= stride_offset < stride]. *)
+          dimension. When [conv] is [Some], this includes convolution parameters. Invariants:
+          [stride > 0], [dilation > 0] (when present), [0 <= stride_offset < stride]. *)
 [@@deriving equal, hash, compare, sexp]
 
 val get_dim : d:int -> ?label:string -> ?proj_id:int -> unit -> dim
@@ -224,4 +224,5 @@ val get_product_proj : proj_env -> dim -> (proj_id * int) option
 
 val proj_to_iterator_exn : proj_env -> proj_id -> Ir.Indexing.symbol
 (** [proj_to_iterator_exn proj_env p] returns the iterator for [p] in [proj_env]. Raises
-    [Invalid_argument] if [p] is not an iterator. *)
+    [Invalid_argument] if [p] is not an iterator. Note that symbols go through substitution when
+    lowering, so these iterators are not the same as the ones in the generated code. *)
diff --git a/test/einsum/test_interleave.expected b/test/einsum/test_interleave.expected
@@ -1 +1,11 @@
-TODO
+Retrieving commandline, environment, or config file variable ocannl_log_level
+Found 0, in the config file
+HERE: test/einsum/test_interleave.ml:14:21
+┌────────────────────────────────┐
+│[2]: interleave shape 0:6       │
+│┌┬─────────────────────────────┐│
+│││axis 0                       ││
+│├┼─────────────────────────────┤│
+│││ 1.00  4.00  ...  3.00  6.00 ││
+│└┴─────────────────────────────┘│
+└────────────────────────────────┘
