Skip to content

fix types #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 28, 2023
Merged

fix types #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d55346
fix types
Vitaly-Protasov Nov 28, 2023
b60118f
Fix typehinting
boomb0om Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DPF/dataset_reader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
)


def help_reader(filesystem: FileSystem, required_columns: Optional[list[str]], path: str):
def help_reader(filesystem: FileSystem, required_columns: Optional[List[str]], path: str):
df = filesystem.read_dataframe(path)

if required_columns:
Expand Down
4 changes: 2 additions & 2 deletions DPF/processors/processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ def to_sharded_files(
max_files_in_shard: int = 1000,
datafiles_ext: str = "csv",
meta_columns: Optional[List[str]] = None,
keys_mapping: Optional[dict[str, str]] = None,
keys_mapping: Optional[Dict[str, str]] = None,
workers: int = 8,
pbar: bool = True
):
Expand All @@ -196,7 +196,7 @@ def to_shards(
datafiles_ext: str = "csv",
archives_ext: Optional[str] = "tar",
meta_columns: Optional[List[str]] = None,
keys_mapping: Optional[dict[str, str]] = None,
keys_mapping: Optional[Dict[str, str]] = None,
workers: int = 8,
pbar: bool = True
):
Expand Down
2 changes: 1 addition & 1 deletion DPF/processors/writers/sharded_files_writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def __init__(
self,
filesystem: FileSystem,
destination_dir: str,
keys_mapping: Optional[dict[str, str]] = None,
keys_mapping: Optional[Dict[str, str]] = None,
max_files_in_shard: int = 1000,
datafiles_ext: str = "csv",
) -> None:
Expand Down
2 changes: 1 addition & 1 deletion DPF/processors/writers/shards_writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def __init__(
self,
filesystem: FileSystem,
destination_dir: str,
keys_mapping: Optional[dict[str, str]] = None,
keys_mapping: Optional[Dict[str, str]] = None,
max_files_in_shard: Optional[int] = 1000,
datafiles_ext: Optional[str] = "csv",
archives_ext: Optional[str] = "tar",
Expand Down