-
Notifications
You must be signed in to change notification settings - Fork 3
fix: add missing expires_seconds argument to test #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missing expires_seconds argument to test #213
Conversation
…_for_test Add missing expires_seconds argument to _get_three_spots_payload_for_test() call in test_platform_test_app_submit_and_wait test. The function requires 1 positional argument but was being called without any. Fixes #211 Co-authored-by: Helmut Hoffer von Ankershoffen né Oertel <helmut-hoffer-von-ankershoffen@users.noreply.github.com>
|
Claude finished @helmut-hoffer-von-ankershoffen's task —— View job ✅ PR Review CompletePR #213: Fix for missing SummaryThis PR correctly fixes a critical bug in ✅ What's Good1. Correct Fix ✅The function signature requires def _get_three_spots_payload_for_test(expires_seconds: int) -> list[platform.InputItem]:The fix at line 302-304 now correctly passes the argument: payload=_get_three_spots_payload_for_test(
expires_seconds=TEST_APPLICATION_SUBMIT_AND_FIND_DEADLINE_SECONDS + 60 * 5
)2. Consistent Pattern ✅The fix follows the exact same pattern used in:
The formula 3. Test Markers Present ✅The test has all required markers: @pytest.mark.skip(reason="v0.0.4 on production balking...")
@pytest.mark.e2e
@pytest.mark.long_running
@pytest.mark.timeout(timeout=TEST_APPLICATION_SUBMIT_AND_WAIT_DEADLINE_SECONDS + 60 * 5)Critical: The 4. Conventional Commit Format ✅
5. Minimal Change ✅The PR changes only what's necessary:
📋 Review Checklist Results
🎯 Technical AnalysisIssue Root CauseThe test was previously calling: payload=_get_three_spots_payload_for_test() # ❌ Missing required argumentThis would have caused a Why It MattersThe
Without this parameter, the test would fail immediately when executed. Test StatusNote that this test is currently skipped with: @pytest.mark.skip(reason="v0.0.4 on production balking on whole_slide_image input...")However, fixing the bug now means:
🔍 Additional ObservationsPositive Patterns Found
✅ Final VerdictAPPROVED ✅ This is a high-quality, necessary bug fix that:
No changes requested. The fix is correct and ready to merge. 📚 References
Reviewed by: Claude Code |
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
|
…_for_test (#213) Add missing expires_seconds argument to _get_three_spots_payload_for_test() call in test_platform_test_app_submit_and_wait test. The function requires 1 positional argument but was being called without any. Fixes #211 Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com> Co-authored-by: Helmut Hoffer von Ankershoffen né Oertel <helmut-hoffer-von-ankershoffen@users.noreply.github.com>



Fixes #211
Added missing
expires_secondsargument to_get_three_spots_payload_for_test()call intest_platform_test_app_submit_and_waittest. The function requires 1 positional argument but was being called without any.Changes
tests/aignostics/platform/e2e_test.pyexpires_seconds=TEST_APPLICATION_SUBMIT_AND_FIND_DEADLINE_SECONDS + 60 * 5Generated with Claude Code