feature: support k8s service discovery. #5
+426
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wangdai-0800
force-pushed
the
service_discover
branch
3 times, most recently
from
f307f7d to
fe28e1c
Compare
taoyuanyuan
reviewed
Nov 13, 2025
Wangdai-0800
force-pushed
the
service_discover
branch
6 times, most recently
from
bdb78a8 to
5f533ea
Compare
fly869
reviewed
Nov 13, 2025
Wangdai-0800
force-pushed
the
service_discover
branch
5 times, most recently
from
b974eb4 to
05c0f1e
Compare
doujiang24
reviewed
Nov 17, 2025
| "google.golang.org/grpc/codes" | ||
| "google.golang.org/grpc/status" | ||
|
|
||
| managertypes "github.com/aigw-project/aigw/pkg/aigateway/clustermanager/types" |
Contributor
There was a problem hiding this comment.
it's not a good idea to reuse the static discovery, introduce a new implementation should be better.
For the code reusing we may introduce a common xds server to avoding copying code, it could be another PR as the second step.
fly869
reviewed
Nov 20, 2025
fly869
reviewed
Nov 20, 2025
Wangdai-0800
force-pushed
the
service_discover
branch
from
05c0f1e to
09c33f1
Compare
Contributor
|
@Wangdai-0800 it's not a good idea to use force push, it makes review changes harder. |
|
|
||
| // updata the snapshot form istio | ||
| func (p *StaticClusterProvider) AutoUpdateFromPilot(nodeID string, interval time.Duration) { | ||
| go func() { |
There was a problem hiding this comment.
The AutoUpdateFromPilot function lacks an exit mechanism. It is recommended to use a for+select loop to ensure it can exit at least when context.Done() is triggered.
| s.responseChan <- resp | ||
| } | ||
|
|
||
| func (s *cdsServerImpl) processSubscribedClusters(subscribeClusters []string) { |
There was a problem hiding this comment.
Add some INFO logs in the key steps to facilitate issue troubleshooting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.