Adds tests and minor refactoring #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds tests to DeepLinkEntry and DeepLinkProcessor - Reduce visibility of internal classes (package-private) - Update project URL in a couple places - Disable gradle daemon (it screws with apt sometimes) - Other random cleanup
Collaborator
There was a problem hiding this comment.
Probably we can just update this comment to show the singular case of @DeepLink
Collaborator
Author
There was a problem hiding this comment.
true dat. will update!
Collaborator
|
Awesome, love the cleanup! 👍 |
felipecsl
added a commit
that referenced
this pull request
Jun 24, 2015
Adds tests and minor refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeepLinkEntryandDeepLinkProcessorDeepLinkEntrynow takes a `Class<?> for the activity instead of a String@cdeonier