Cleanup before v1.0

[austinbyers]

A collection of minor code cleanups before releasing v1.0 of BinaryAlert!

Bug Fixes

• terraform init is required before any other terraform operation (fixes deploys; thanks @fusionrace for flagging)
• Unit tests no longer do a real pip install of downloader dependencies

Code Changes

• Adds last_seen and webui_link to CarbonBlack metadata saved in the downloader
• Uses higher-level boto3 resources when applicable to simplify the code (resolves: Use higher-level boto3 resources #42)
• Finishes type annotations and enforces type-checking with mypy (resolves: Use type annotations #34)

Terraform Changes

• Adds force_destroy variable to optionally allow complete terraform destroy of S3 buckets
• Doubles dispatch limit (from 50 to 100) to better accommodate batch operations

Test Changes

• Simplifies mocking and removes moto completely
• Mocks out all print/logging statements (resolves: Mock out loggers during unit tests #43)
• Increase test coverage by 6%

Tested

python3 manage.py configure  # no downloader
python3 manage.py deploy
python3 manage.py live_test
python3 manage.py configure # downloader
python3 manage.py clone_rules
python3 manage.py deploy
python3 manage.py live_test
# Manual test of downloader

Reviewers

to: @ryandeivert
cc: @airbnb/binaryalert-maintainers

[coveralls]

Coverage increased (+6.06%) to 95.52% when pulling 4595c5f on abb--cleanup into 510f94a on master.

[ryandeivert]

Nice work on this!

[ryandeivert]

super interesting syntax for this

[austinbyers]

Yeah, I actually didn't realize for awhile that you could annotate variables. But that explains why method arguments are annotated the same way (with default values), e.g.

def func(path: Optional[str] = None)

[coveralls]

Coverage increased (+6.06%) to 95.52% when pulling 58730be on abb--cleanup into 4298b99 on master.