Skip to content

Ambiguous 'good' example #1637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vorpus wants to merge 2 commits into from
Closed

Ambiguous 'good' example #1637

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ac3411
Ambiguous 'good' example
vorpus Nov 7, 2017
5c532b6
Update README.md
vorpus Nov 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -806,8 +806,9 @@ Other Style Guides
const h = function() {};

// good
const x = function () {};
const x = () => {};
Copy link
Collaborator

@ljharb ljharb Nov 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an arrow function doesn't have the spacing issue this section is concerned with; the fact that function () {} is bad doesn't mean it's not useful in this example.

I'm fine adding the arrow, but we need to keep the function () {}.

Copy link
Author

@vorpus vorpus Nov 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ljharb Yea I was thinking about that after I made the PR - added line 811 with a function that has a longer lexical name

Copy link
Author

@vorpus vorpus Nov 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ljharb You're probably right, it's too trivial of an inconsistency to not keep what is currently in the doc

const y = function a() {};
const z = function abc() {};
```

<a name="functions--mutate-params"></a><a name="7.12"></a>
Expand Down