Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eslint config][major][guide] Always require parens around arrow function arguments #1863

Merged
merged 1 commit into from Aug 9, 2019

Conversation

@sharmilajesupaul
Copy link
Contributor

commented Jul 10, 2018

guide + eslint config change to always require parens around arrow function arguments.

@sharmilajesupaul sharmilajesupaul requested a review from ljharb Jul 10, 2018

@sharmilajesupaul sharmilajesupaul force-pushed the shar--always-use-parens-for-arrow-functions branch 2 times, most recently from 0ca14dc to 21ef5e4 Jul 10, 2018

@tunnckoCore

This comment has been minimized.

Copy link

commented Jul 10, 2018

Yeaaaah!! 🎉 :)

@ljharb

This comment has been minimized.

Copy link
Collaborator

commented Jul 10, 2018

Thanks - since this is a semver-major, I'm going to hold off on merging it until after #1834 is released.

@ljharb ljharb self-assigned this Jul 10, 2018

@ljharb
Copy link
Collaborator

left a comment

LGTM, but blocking merges until it's ready


> Why? Less visual clutter.
> Why? Minimizes diff churn when adding or removing arguments.

This comment has been minimized.

Copy link
@lencioni

lencioni Jul 10, 2018

Member

This is a much better reason!

@sharmilajesupaul sharmilajesupaul force-pushed the shar--always-use-parens-for-arrow-functions branch from 21ef5e4 to 020bdde Jul 10, 2018

@ljharb ljharb force-pushed the shar--always-use-parens-for-arrow-functions branch from 020bdde to cf6219d Aug 13, 2018

@alexzherdev

This comment has been minimized.

Copy link

commented Oct 27, 2018

Since #1834 is done now, can this be rebased and merged?

@ljharb ljharb force-pushed the shar--always-use-parens-for-arrow-functions branch from bb12bcd to 95f33e7 Nov 29, 2018

Show resolved Hide resolved README.md Outdated

@ljharb ljharb force-pushed the shar--always-use-parens-for-arrow-functions branch from 95f33e7 to cf57435 Dec 6, 2018

@ljharb ljharb force-pushed the shar--always-use-parens-for-arrow-functions branch from e1cef35 to 820745d Aug 9, 2019

@ljharb

ljharb approved these changes Aug 9, 2019

Copy link
Collaborator

left a comment

it is time

@ljharb ljharb merged commit 820745d into master Aug 9, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ljharb ljharb deleted the shar--always-use-parens-for-arrow-functions branch Aug 9, 2019

@tunnckoCore

This comment has been minimized.

Copy link

commented Aug 10, 2019

Sweeet. One more rule which I like and forced in my config, got merged. :)
So I guess, I'm not that bad at decisions and logical & good style ;p

@ljharb ljharb referenced this pull request Aug 14, 2019

Closed

Example in 8.2 confusing #2071

ljharb added a commit that referenced this pull request Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.