Issue 1023 pass invalid date to onchange #2015
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 30, 2020 14:51
When a date is invalid, it is hard to tell if it is invalid due to an empty string, where the user has not entered a date, or if the user entered an invalid date. Currently the only way to determine if the date is invalid or just empty, is to query the DOM for the specific tags to read their values. This change will pass a new argument to the onChangeHandler that will include the date string that was entered into the input.
Author
|
handled by #1941 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve issue 1023
When a date is invalid, it is hard to tell if it is invalid due to an empty string, where the user has not entered a date, or if the user entered an invalid date.
Currently the only way to determine if the date is invalid or just empty, is to query the DOM for the specific tags to read their values.
This change will pass a new argument to the onChangeHandler that will include the date string that was entered into the input.
There were some unrelated files that had linting errors related to having too many spaces. This PR also helps the team out in fixing those issues.