Skip to content

Update peerDependencies in package.json #2024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MichaelDeBoey wants to merge 1 commit into from
Closed

Update peerDependencies in package.json #2024

MichaelDeBoey wants to merge 1 commit into from

Conversation

@MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented Jul 14, 2020

ljharb
ljharb requested changes Jul 16, 2020
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely not; it's highly dangerous to use >= in a dependencies field, especially peer deps.

@ljharb ljharb added the wontfix Sadly, we're not interested in implementing this. label Jul 16, 2020
@ljharb ljharb closed this Jul 16, 2020
@MichaelDeBoey MichaelDeBoey deleted the patch-3 branch July 16, 2020 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharb ljharb ljharb requested changes

Assignees

No one assigned

Labels

wontfix Sadly, we're not interested in implementing this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MichaelDeBoey @ljharb