added aria-expanded and aria-describedBy to the calender icon for acc… #2142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Aug 27, 2021
Member
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
Unrelated styling changes need to be reverted.
stories/DateRangePicker.js
Outdated
Comment on lines
60
to
63
| .add( | ||
| "default", | ||
| withInfo()(() => <DateRangePickerWrapper />) | ||
| ) |
Member
There was a problem hiding this comment.
please revert the styling changes here, it's indented and lined properly as-is. also make sure your editor isn't blindly running prettier on a project that isn't using it :-)
Contributor
Author
There was a problem hiding this comment.
Sorry about that! First time contributing, I didn't even realize I had done that. I've fixed it in my last change, thanks!
Contributor
Author
|
Is there something more I should be doing for this to be merged? Thanks! |
…mplete prop into readme
…ing test and added to storybook for visual verification of attribute
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cessibility
This pull request adds the ability to inform screen reader users about the calendar icon's state and role.
Any text passed into the new
ariaDescribedByprop will give screen reader users the appropriate context for it. TheariaExpandedprop will tell screen reader users the state of the calendar.