Update conditions when adjustDayPickerHeight is called

[nboliver]

No description provided.

[coveralls]

Coverage increased (+0.02%) to 83.927% when pulling aea2784 on nboliver:daypicker_height into a5fb097 on airbnb:master.

[majapw]

Can you explain the motivation for why you want to do this? Because reaching into the child component to grab a method is generally an antipattern.

[nboliver]

Updated this PR in response to your comments in the issue. Let me know if you think that covers the possible situations when it might need to update.

[coveralls]

Coverage decreased (-0.2%) to 83.728% when pulling 877cd7e on nboliver:daypicker_height into 782b5f3 on airbnb:master.

[coveralls]

Coverage decreased (-0.2%) to 83.728% when pulling 811212a on nboliver:daypicker_height into 782b5f3 on airbnb:master.

[nboliver]

@majapw Any further thoughts on this? I was wondering if maybe adjustDayPickerHeight should always be called when the component receives props. It's a tough balance between performance and making sure it is always the correct dimensions.

componentWillReceiveProps(nextProps) {
...
  if (this.isHorizontal()) {
    this.adjustDayPickerHeight();
  }
...
}

[ljharb]

This needs a rebase and some sort of test coverage.

[coveralls]

Coverage decreased (-0.2%) to 83.781% when pulling add3b41 on nboliver:daypicker_height into 3815516 on airbnb:master.

[nboliver]

@ljharb rebased - anything else required? what do you think of my comment above about calling adjustDayPickerHeight every time the component receives props?

[coveralls]

Coverage increased (+0.07%) to 84.03% when pulling 3750622 on nboliver:daypicker_height into 3815516 on airbnb:master.

[majapw]

Not super sure why this isn't just integrated into the above conditional? Let's make that change and then merge this in.

[ljharb]

I think it still needs nonzero test coverage before going in tho, if possible.

[brosewarne]

I've attempted to update / finish this in #640

[majapw]

Closing in favor of #640