Test using prettier for formatting#809
Closed
aboyton wants to merge 1 commit intoreact-dates:masterfrom
Closed
Conversation
This is a proof-of-concept to using prettier to format this code. It is not intended to be merged, it is designed to show that prettier is a lot more strict in code style than standard ESLint rules are.
Author
|
I'm going to close this as I'm assuming you don't want to merge this, but feel free to reopen if you are actually interested. |
Member
|
This is definitely noise (you can make a branch without creating a pull request, if your goal is to demonstrate a diff), and it's not about being "strict" it's about "actually doing what we want", which prettier by default decidedly does not. Please do not make any pull requests of this nature in the future; airbnb/javascript#1548 seems pretty clear, and if this changes, we'll modify our own code style to match it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry about the noise.
This is a proof-of-concept to using prettier to format this code. It is not intended to be merged, it is designed to show that prettier is a lot more strict in code style than standard ESLint rules are.
airbnb/javascript#1548