-
Notifications
You must be signed in to change notification settings - Fork 30
feat: add base64binascii_decode
to Jinja interpolation
#424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add base64binascii_decode
to Jinja interpolation
#424
Conversation
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
base64binascii_decode
to Jinja interpolation
📝 WalkthroughWalkthroughA new function Changes
Sequence Diagram(s)sequenceDiagram
participant Jinja as "Jinja2 Engine"
participant Filter as "base64binascii_decode Filter"
Jinja->>Filter: Call base64binascii_decode(value)
Filter-->>Jinja: Return decoded ASCII string
Would you like any further refinements or additional diagrams, wdyt? Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms (9)
🔇 Additional comments (1)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
airbyte_cdk/sources/declarative/interpolation/filters.py
(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Check: 'source-shopify' (skip=false)
- GitHub Check: Pytest (All, Python 3.11, Ubuntu)
- GitHub Check: Pytest (All, Python 3.10, Ubuntu)
🔇 Additional comments (1)
airbyte_cdk/sources/declarative/interpolation/filters.py (1)
138-138
: Adding new filter to the filters list looks goodThe addition of the new filter to
_filters_list
is correct and ensures the filter is registered properly. As a minor nitpick, would you consider sorting the filters alphabetically for easier maintenance in the future? Just a thought!
Summary by CodeRabbit