Skip to content

Feat/ava #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2025
Merged

Feat/ava #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64e71e1
#76
elchris97 May 8, 2025
d2e73a5
#76 add jp fonts, float nav, smaller portrait
elchris97 May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions _data/members.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,20 +38,20 @@
url: https://scholar.google.co.jp/citations?hl=ja&user=c_62MhUAAAAJ
badges: []

- name: T.T. Nguyen NGUYEN
name_jp: T.T. Nguyen Nguyen
- name: Nguyen NGUYEN
name_jp: Nguyen Nguyen
role: phd
image: /images/nguyen_ava.jpeg
url: https://nguyenntt97.github.io/
badges: [3D Face, Generative]
badges: [Generative]
date: 2023-09-01

- name: Bach Thuan BUI
name_jp: Bach Thuan Bui
role: phd
image: /images/team/thuan.png
url: https://thuanbb.github.io/
badges: [Visual SLAM]
badges: [Vision]
date: 2022-09-01

- name: Ardiansyah Al FAROUQ
Expand All @@ -67,23 +67,23 @@
role: phd
image: /images/team/dummy.png
url:
badges: [Medical Robotics]
badges: [Medical]
date: 2024-09-01

- name: Yuki MATSUSHITA
name_jp: 松下　優希
role: phd
image: /images/team/dummy.png
url:
badges: [Field Robotics]
badges: [Field]
date: 2025-04-01

- name: Shu YOSHIDA
name_jp: 吉田　集
role: phd
image: /images/team/phd/yoshida.jpg
url: https://sites.google.com/view/yosshu
badges: [Computer Vision]
badges: [Vision]
date: 2025-04-01

# Master students (m)
Expand Down
2 changes: 1 addition & 1 deletion _includes/header.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
{% assign logo = svg | default: png | default: jpg | default: nil %}

<header
class="background"
class="background header"
style="--image: url('{{ image | uri_escape }}')"
{% if dark == true or dark == false %}
data-dark="{{ dark }}"
Expand Down
31 changes: 16 additions & 15 deletions _includes/portrait.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,7 @@
{% assign type = site.data.types[member.role] %}

<div class="portrait-wrapper">
<a
{% if member.url != nil %}
href="{{ member.url | relative_url | uri_escape }}"
{% endif %}
<div
class="portrait"
data-style="{{ include.style }}"
aria-label="{{ member.name | default: "member link" | regex_strip }}"
Comment on lines +24 to 27
Copy link

Copilot AI May 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Review the removal of the wrapping anchor around the portrait image to ensure that the intended interactive area for users is preserved.

Suggested change
<div
class="portrait"
data-style="{{ include.style }}"
aria-label="{{ member.name | default: "member link" | regex_strip }}"
<a
class="portrait"
data-style="{{ include.style }}"
aria-label="{{ member.name | default: "member link" | regex_strip }}"
{% if member.url != nil %}
href="{{ member.url | relative_url | uri_escape }}"
{% endif %}

Copilot uses AI. Check for mistakes.
Expand All @@ -36,16 +33,6 @@
{% include fallback.html %}
></div>

{% if member.name %}
<span class="portrait-name">
{% if site.lang == "jp" %}
{{ member.name_jp }}
{% else %}
{{ member.name }}
{% endif %}
</span>
{% endif %}

{% if member.description or type %}
<span class="portrait-description">
{% if site.lang == "jp" %}
Expand All @@ -54,17 +41,31 @@
{{ member.description | default: type.description }}{% if member.role != "pi" and member.role != "ap" and member.role != "pd" and member.role != "vr" and member.role != "s" and member.role != "is" %}{{seniority}}{% endif %}
{% endif %}
</span>

<span class="badges">
{% for badge in member.badges %}
<span class="badge">{{ badge }}</span>
{% endfor %}
</span>
{% if member.name %}
<a {% if member.url != nil %}
href="{{ member.url | relative_url | uri_escape }}"
{% endif %}>
<span class="portrait-name">
{% if site.lang == "jp" %}
{{ member.name_jp }}
{% else %}
{{ member.name }}
{% endif %}
</span>
</a>
{% endif %}
{% endif %}

{% if member.affiliation %}
<span class="portrait-affiliation">
{{ member.affiliation }}
</span>
{% endif %}
</a>
</div>
</div>
2 changes: 1 addition & 1 deletion _layouts/default.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<!DOCTYPE html>
<html lang="en" data-dark="false">
<html lang={{site.lang}} data-dark="false">
{% include head.html %}
<body>
{% include header.html %}
Expand Down
29 changes: 27 additions & 2 deletions _scripts/anchors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,35 @@
window.addEventListener("hashchange", scrollToTarget);

// change header to sticky if scrolled past 0.25 of the page and not data-big-header
let dataBigTimeout;
window.addEventListener("scroll", () => {
const header = document.querySelector("header");
if (!header) return;
if (header.hasAttribute("data-big")) return;
header.classList.toggle("sticky", window.scrollY > 100);

const scrollY = window.scrollY;
// if at root
clearTimeout(dataBigTimeout);
dataBigTimeout = setTimeout(() => {
Comment on lines +49 to +57
Copy link

Copilot AI May 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider using requestAnimationFrame for scroll event handling to achieve smoother UI updates.

Copilot uses AI. Check for mistakes.
if (window.location.pathname.replaceAll(/\/(en|jp)/g, "") === "/") {
const is_big = header.hasAttribute("data-big");

if (scrollY > 200 && !is_big) {
header.classList.add("sticky");
} else {
header.classList.remove("sticky");
}

if (scrollY > 240) {
header.removeAttribute("data-big");
return;
}
if (!is_big && (scrollY < 100)) {
header.setAttribute("data-big", "");
return;
}
}
}, 100);

// header.classList.toggle("sticky", window.scrollY > 100);
});
}
8 changes: 8 additions & 0 deletions _styles/-theme.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,3 +58,11 @@
--shadow: 0 0 10px 0 var(--overlay);
--transition: 0.2s ease;
}


// Japanese override
:lang(jp) {
--title: "Noto Sans JP", "Hiragino Kaku Gothic ProN", Meiryo, sans-serif;
--heading: "Noto Sans JP", "Hiragino Kaku Gothic ProN", Meiryo, sans-serif;
--body: "Noto Sans JP", "Hiragino Kaku Gothic ProN", Meiryo, sans-serif;
}
2 changes: 1 addition & 1 deletion _styles/portrait.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
align-items: center;
flex-direction: column;
margin: 20px;
width: 175px;
width: 100px;
Copy link

Copilot AI May 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Ensure the new width is intentional and consistent with the overall design requirements.

Suggested change
width: 100px;
width: var(--portrait-width, 100%);

Copilot uses AI. Check for mistakes.
max-width: calc(100% - 20px - 20px);
text-decoration: none;

Expand Down