Skip to content

Fix ModelFactory list method #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 4, 2023
Merged

Fix ModelFactory list method #83

merged 2 commits into from
Oct 4, 2023

Conversation

@lucas-aixplain
Copy link
Contributor

@lucas-aixplain lucas-aixplain commented Oct 4, 2023 •
edited
Loading

In ModelFactory list method:

  • Renamed functions to function parameter.
  • Updated filter_params not to use string values.
  • Updated FineTune unit test to mock new endpoint from the backend.

Task: M-5263087343, M-5267676901 and M-5267256945

@mikelam-us-aixplain mikelam-us-aixplain merged commit 5027818 into main Oct 4, 2023
@thiago-aixplain thiago-aixplain deleted the M-5263087343-fixModelList branch October 5, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MAlyafeai18 MAlyafeai18 Awaiting requested review from MAlyafeai18

@thiago-aixplain thiago-aixplain Awaiting requested review from thiago-aixplain

1 more reviewer

@mikelam-us-aixplain mikelam-us-aixplain mikelam-us-aixplain approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lucas-aixplain @mikelam-us-aixplain