elvis: wip

Author: 1st1

asyncpg/protocol/codecs/record.pyx

@@ -51,10 +51,25 @@ cdef anonymous_record_decode(ConnectionSettings settings, FRBuffer *buf):
     return result
 
 
+cdef anonymous_record_decode_ex(ConnectionSettings settings, FRBuffer *buf,
+                                const void *arg):
+    return anonymous_record_decode(settings, buf)
+
+
+cdef anonymous_record_array_decode(ConnectionSettings settings, FRBuffer *buf):
+    return array_decode(
+        settings, buf, <decode_func_ex>&anonymous_record_decode_ex, NULL)
+
+
 cdef init_record_codecs():
     register_core_codec(RECORDOID,
                         <encode_func>NULL,
                         <decode_func>anonymous_record_decode,
                         PG_FORMAT_BINARY)
 
+    register_core_codec(_RECORDOID,
+                        <encode_func>NULL,
+                        <decode_func>anonymous_record_array_decode,
+                        PG_FORMAT_BINARY)
+
 init_record_codecs()

asyncpg/protocol/pgtypes.pxi

@@ -79,6 +79,7 @@ DEF LANGUAGE_HANDLEROID = 2280
 DEF INTERNALOID = 2281
 DEF OPAQUEOID = 2282
 DEF ANYELEMENTOID = 2283
+DEF _RECORDOID = 2287
 DEF ANYNONARRAYOID = 2776
 DEF UUIDOID = 2950
 DEF TXID_SNAPSHOTOID = 2970
@@ -99,7 +100,7 @@ DEF EVENT_TRIGGEROID = 3838
 DEF REGNAMESPACEOID = 4089
 DEF REGROLEOID = 4096
 
-cdef ARRAY_TYPES = (_TEXTOID, _OIDOID,)
+cdef ARRAY_TYPES = (_TEXTOID, _OIDOID, _RECORDOID,)
 
 BUILTIN_TYPE_OID_MAP = {
     ABSTIMEOID: 'abstime',
@@ -187,6 +188,7 @@ BUILTIN_TYPE_OID_MAP = {
     XIDOID: 'xid',
     XMLOID: 'xml',
     _OIDOID: 'oid[]',
+    _RECORDOID: 'record[]',
     _TEXTOID: 'text[]'
 }
 

tests/test_codecs.py

@@ -754,6 +754,10 @@ async def test_arrays(self):
                 r"SELECT '{}'::int[]",
                 []
             ),
+            (
+                r"SELECT ARRAY[(1, 2)]",
+                [(1, 2)]
+            )
         ]
 
         for sql, expected in cases:

tools/generate_type_map.py

@@ -16,7 +16,7 @@
 # Array types with builtin codecs, necessary for codec
 # bootstrap to work
 #
-_BUILTIN_ARRAYS = ('_text', '_oid')
+_BUILTIN_ARRAYS = ('_text', '_oid', '_record')
 
 _INVALIDOID = 0