API-487: Isolate files manipulation in a dedicated service #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaurentPetard
force-pushed
the
API-487
branch
2 times, most recently
from
e91d5c3 to
1a1d09f
Compare
ahocquard
reviewed
Jan 4, 2018
| * | ||
| * @param string $filePath Path of the file | ||
| * | ||
| * @throws InvalidArgumentException if the file doesn't exists or is not readable |
Collaborator
There was a problem hiding this comment.
create a dedicated exception seems a good idea as you have a dedicated interface (and exception are not BC break in php)
ahocquard
approved these changes
Jan 4, 2018
momoss
approved these changes
Jan 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to avoid to execute
fopenand handle errors directly in API services.