API-599: replace integration tests by end-to-end tests #132

Doodoune · 2018-04-27T13:11:56Z

Replace all integration tests by end-to-end tests using "donatj/mock-webserver".

ahocquard · 2018-05-17T11:32:40Z

.travis.yml

+language: php
+
+php:
+    - 7.1


ahocquard · 2018-05-17T11:41:30Z

tests/Api/ApiTestCase.php

+    /**
+     * @return StreamFactory
+     */
+    protected function getStreamFactory()


where is it used?

In UpsertListProductTest sur le test test_upsert_list_from_stream

not needed to share with every tests in this case.
And if it's function shared across several test, it's a good candidate about using a trait.

ahocquard · 2018-05-17T11:42:45Z

tests/Api/CreateProductMediaFileTest.php

+            'locale'     => null,
+        ]);
+
+        $this->assertSame('f/b/0/6/fb068ccc9e3c5609d73c28d852812ba5faeeab28_akeneo.png', $response);


Assert::assertSame

Check in the history of the response stack (take a look at the library documentation) what if the body of the request what what we expects.
For now, you are just checking the URI call.

ahocquard · 2018-05-17T11:59:42Z

tests/Api/CreateProductTest.php

+        $api = $this->createClient()->getProductApi();
+        $response = $api->create('new_shoes', $this->newProduct());
+
+        $this->assertSame(201, $response);


same (almost evrywhere): check the body of the request. You can do a function in ApiTestCase.

ahocquard · 2018-05-17T12:00:05Z

tests/Api/ListPerPageProductTest.php

+        $api = $this->createClient()->getProductApi();
+        $firstPage = $api->listPerPage(10, true, []);
+
+        $this->assertInstanceOf(PageInterface::class, $firstPage);


Changed everywere

…entation to test with docker

LaurentPetard · 2018-05-22T14:33:44Z

composer.json

    "php-http/multipart-stream-builder": "^1.0",
-    "php-http/client-implementation": "^1.0"
+    "php-http/client-implementation": "^1.0",
+    "php-http/guzzle6-adapter": "^1.1"


Both in "require" and "require-dev" ? I think it shouldn't be in "require"

Doodoune · 2018-05-22T15:50:42Z

@LaurentPetard I remove both, we add it by composer require in the doc so I don't have to add it in composer.json

ahocquard · 2018-05-22T07:50:48Z

tests/Api/CreateProductMediaFileTest.php

+        $response = $api->create($mediaFile, $productInfos);
+
+        Assert::assertSame($this->server->getLastRequest()->jsonSerialize()[RequestInfo::JSON_KEY_POST]['product'], json_encode($productInfos));
+        Assert::assertSame($this->server->getLastRequest()->jsonSerialize()[RequestInfo::JSON_KEY_REQUEST_URI], '/'. ProductMediaFileApi::MEDIA_FILES_URI);


useless line

ahocquard · 2018-05-22T18:07:09Z

phpunit.xml.dist

     convertNoticesToExceptions="true"
     convertWarningsToExceptions="true"
-     processIsolation="true"
+     processIsolation="false"


you can keep it at true (maybe my commit which did that)

Yeah, I change that

ahocquard · 2018-05-22T18:07:54Z

src/Search/Operator.php

    const LOWER_THAN_ON_ALL_LOCALES = 'LOWER THAN ON ALL LOCALES';
    const LOWER_OR_EQUALS_THAN_ON_ALL_LOCALES = 'LOWER OR EQUALS THAN ON ALL LOCALES';
-    const EMPTY = 'EMPTY';
+    const IS_EMPTY = 'EMPTY';


no, this is a BC

at the end, we will have to change it because it is not supported by php 5.6.... it's a kind of bug

ahocquard · 2018-05-22T18:12:00Z

tests/Api/CreateProductTest.php

+        $api = $this->createClient()->getProductApi();
+        $response = $api->create('new_shoes', $this->newProduct());
+
+        Assert::assertSame($this->server->getLastRequest()->jsonSerialize()[RequestInfo::JSON_KEY_INPUT], json_encode(array_merge($this->newProduct(), ["identifier" => "new_shoes"])));


I'm not a fan of it.

You are doing logic inside your test by doing array_merge. Avoid that.
Put directly what you are expecting. Copy past in test is not a problem.

(it means that the function newProduct is usless)

ahocquard · 2018-05-22T18:14:24Z

tests/Api/DownloadProductMediaFileTest.php

+{
+    public function test_download_media_file()
+    {
+        $expectedMediaFile = realpath(__DIR__ . '/../fixtures/akeneo.png');


FilePath, FIle is for generally for a ressource

ahocquard · 2018-05-22T18:15:58Z

tests/Api/ListPerPageProductTest.php

+        Assert::assertSame($this->server->getServerRoot() . '/api/rest/v1/products?page=2&with_count=true&pagination_type=page&limit=10', $firstPage->getNextLink());
+        Assert::assertEquals(count($firstPage->getItems()), 10);
+
+        $secondPage = $firstPage->getNextPage();


assert the last request for the query parametesrs

It's already present a few line before : Assert::assertSame($this->server->getLastRequest()->jsonSerialize()[RequestInfo::JSON_KEY_GET], ['limit' => '10', 'with_count' => 'true']);

yes, but nextPage does another new request. It's a cursor under the hood. So you have to check that this new call is done with good query parameters

ahocquard · 2018-05-22T18:18:27Z

Almost GTM: please revert the BC break

ahocquard · 2018-05-23T07:52:11Z

src/Search/Operator.php

    const LOWER_THAN_ON_ALL_LOCALES = 'LOWER THAN ON ALL LOCALES';
    const LOWER_OR_EQUALS_THAN_ON_ALL_LOCALES = 'LOWER OR EQUALS THAN ON ALL LOCALES';
-    const EMPTY = 'EMPTY';
+    const IS_EMPTY = 'EMPTY';


at the end, we will have to change it because it is not supported by php 5.6.... it's a kind of bug

Doodoune force-pushed the API-599 branch from 8c082ec to e0cc6e5 Compare April 27, 2018 13:17

Doodoune and others added 2 commits April 27, 2018 17:02

API-599: replace integration tests by end-to-end tests

a32d5f6

API-599: change jenkinsfile to launch end-to-end tests

591fa0b

Doodoune force-pushed the API-599 branch from 32bc866 to 591fa0b Compare April 27, 2018 15:03

API-599: change jenkinsfile to launch end-to-end tests

a01f91b

Doodoune force-pushed the API-599 branch from a5bf051 to a01f91b Compare May 2, 2018 10:03

Doodoune force-pushed the API-599 branch 7 times, most recently from ac2c5d5 to 0621a09 Compare May 17, 2018 10:01

ahocquard reviewed May 17, 2018

View reviewed changes

Doodoune force-pushed the API-599 branch 7 times, most recently from 20ef38e to 579ced8 Compare May 18, 2018 08:39

API-599: add travis

e0dd70d

Doodoune force-pushed the API-599 branch from 579ced8 to e0dd70d Compare May 18, 2018 08:43

API-599: fix composer install by deleting composer.lock and add docum…

f82bfe6

…entation to test with docker

ahocquard force-pushed the API-599 branch 3 times, most recently from 9061ee0 to 6221347 Compare May 18, 2018 09:58

Doodoune force-pushed the API-599 branch 3 times, most recently from 5b31354 to b2083d4 Compare May 18, 2018 12:17

Doodoune force-pushed the API-599 branch 3 times, most recently from 0b85c57 to 5d3cba1 Compare May 18, 2018 12:25

ahocquard force-pushed the API-599 branch 2 times, most recently from 1ac139f to cf0b8cb Compare May 18, 2018 12:34

Doodoune force-pushed the API-599 branch 3 times, most recently from 7755bcc to e5b639e Compare May 18, 2018 15:26

API-599: fix composer install by deleting composer.lock and add docum…

c650a6d

…entation to test with docker

Doodoune force-pushed the API-599 branch 3 times, most recently from 74d9d02 to 1aacf98 Compare May 22, 2018 13:02

LaurentPetard approved these changes May 22, 2018

View reviewed changes

Doodoune force-pushed the API-599 branch 3 times, most recently from 2dc0d86 to 97cca32 Compare May 22, 2018 15:48

ahocquard reviewed May 22, 2018

View reviewed changes

Doodoune force-pushed the API-599 branch 3 times, most recently from 6f14728 to 0e4cf53 Compare May 23, 2018 07:30

API-599: correct tests

e3c6d8c

Doodoune force-pushed the API-599 branch 2 times, most recently from 2f39841 to e2fcf8f Compare May 23, 2018 07:51

API-599: fix const not supported by PHP 5.6

80f889d

Doodoune force-pushed the API-599 branch from e2fcf8f to 80f889d Compare May 23, 2018 07:52

ahocquard approved these changes May 23, 2018

View reviewed changes

Doodoune merged commit 44ed422 into 1.0 May 23, 2018

Doodoune deleted the API-599 branch May 23, 2018 07:55

API-599: replace integration tests by end-to-end tests #132

API-599: replace integration tests by end-to-end tests #132

Uh oh!

Conversation

Doodoune commented Apr 27, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ahocquard May 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LaurentPetard May 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Doodoune commented May 22, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ahocquard commented May 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ahocquard May 18, 2018 •

edited

Loading

LaurentPetard May 22, 2018 •

edited

Loading

ahocquard commented May 22, 2018 •

edited

Loading