Refactor upsert list #152
Merged
Refactor upsert list #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamarasaurus
approved these changes
Jan 18, 2019
ahocquard
approved these changes
Jan 18, 2019
LaurentPetard
force-pushed
the
refactor-upsert-list
branch
from
6fddb48 to
dd9ac0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the end-points of the reference entities, we changed the way of patching resources. The requests bodies are a single JSON instead of bodies containing one JSON per line. Same for the responses.
So I added a method in the resource client to be able to patch several resources using only one JSON for the request and the response.
I renamed the method
upsertResourceListto avoid any confusion.