Explain numerical stability concerns with matrix inversion in Kalman filter #69
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed review question about why
np.linalg.inv(S)is considered numerically unstable in the Kalman gain computation.Explanation provided
The current implementation on line 62 of
kf_emulator.py:Computing explicit matrix inverse amplifies numerical errors for ill-conditioned matrices. In Kalman filtering, the innovation covariance
Scan become ill-conditioned when observation noise is small or predicted covariance has disparate magnitudes across dimensions.Using
np.linalg.solve(S, rhs)instead:Sis nearly singularThe mathematically equivalent but more stable form:
No code changes made in this PR—purely explanatory response to review comment.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.