fix(rules): 'use-simple-repeaters' fails if variable is used as a locator

Author: alecxe

lib/rules/use-simple-repeaters.js

@@ -13,25 +13,26 @@ module.exports = {
   create: function (context) {
     return {
       'CallExpression': function (node) {
-        if (node.arguments) {
+        if (node.arguments && node.arguments[0] && node.arguments[0].hasOwnProperty('value')) {
           var object = node.callee.object
           var property = node.callee.property
 
           if (object && property && object.name === 'by' && property.name === 'repeater') {
             var repeaterValue = node.arguments[0].value
+            if (repeaterValue) {
+              if (repeaterValue.indexOf('|') > 0) {
+                context.report({
+                  node: node,
+                  message: 'Unexpected filter inside a by.repeater() locator.'
+                })
+              }
 
-            if (repeaterValue.indexOf('|') > 0) {
-              context.report({
-                node: node,
-                message: 'Unexpected filter inside a by.repeater() locator.'
-              })
-            }
-
-            if (repeaterValue.indexOf('track by') > 0) {
-              context.report({
-                node: node,
-                message: 'Unexpected "track by" inside a by.repeater() locator.'
-              })
+              if (repeaterValue.indexOf('track by') > 0) {
+                context.report({
+                  node: node,
+                  message: 'Unexpected "track by" inside a by.repeater() locator.'
+                })
+              }
             }
           }
         }

test/rules/use-simple-repeaters.js

@@ -8,7 +8,11 @@ var eslintTester = new RuleTester()
 eslintTester.run('use-simple-repeaters', rule, {
   valid: [
     'element.all(by.repeater("item in items"));',
-    'element.all(by.exactRepeater("item in items"));'
+    'element.all(by.exactRepeater("item in items"));',
+    'element.all(by.repeater(arg));',
+    'element.all(by.exactRepeater(arg));',
+    'element.all(by.repeater());',
+    'element.all(by.repeater(undefined));'
   ],
 
   invalid: [