Skip to content

Conversation

@1yam
Copy link
Member

@1yam 1yam commented Nov 10, 2025

Jira Ticket: 658

This PR goal is to add a new service Settings to be able to fetch currents network settings on:
Network Settings Aggregates


This pull request introduces a new service for accessing network settings, specifically focused on retrieving GPU compatibility and related network configuration data. The main changes include the addition of the Settings service, integration of this service into the main HTTP client, and the creation of comprehensive unit tests to validate its behavior.

New Network Settings Service:

  • Added Settings service (Settings class) in src/aleph/sdk/client/services/settings.py to handle logic around network settings, including a model (NetworkSettingsModel) for compatible GPUs and other network configuration fields.
  • Implemented method get_settings_aggregate in the Settings service to fetch configuration data from the aggregate using a specific address.

Integration:

  • Registered the new Settings service as self.settings within the main HTTP client (AlephHttpClient) for easier access to network settings. [1] [2]

Testing:

  • Added a new unit test file tests/unit/services/test_settings.py that mocks the aggregate response and verifies the correct parsing and retrieval of GPU compatibility and other network settings.

@1yam 1yam requested review from nesitor and odesenfans November 10, 2025 13:18
@github-actions
Copy link

Failed to retrieve llama text: POST 503:

503 Service Unavailable


No server is available to handle this request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants