-
Notifications
You must be signed in to change notification settings - Fork 18
Implement Credits payment on Notify endpoint #834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e8e3f61 to
08a33ec
Compare
1yam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1yam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cd1fcbb to
47ac652
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #834 +/- ##
==========================================
- Coverage 64.84% 64.67% -0.18%
==========================================
Files 87 87
Lines 8095 8121 +26
Branches 723 733 +10
==========================================
+ Hits 5249 5252 +3
- Misses 2620 2642 +22
- Partials 226 227 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Feature: Support Credits payment method on the notify endpoint.
Self proofreading checklist
packaging/MakefileChanges
Integrated credits payment method on the notify endpoint
How to test
Try to send an instance using credits payment method and notify it on the CRN.